chore: add explicit discriminator field for processors #145
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeknep
reviewed
Dec 17, 2025
src/data_designer/engine/dataset_builders/utils/config_compiler.py
Outdated
Show resolved
Hide resolved
johnnygreco
reviewed
Dec 17, 2025
| default=BuildStage.POST_BATCH, | ||
| description=f"The stage at which the processor will run. Supported stages: {', '.join(SUPPORTED_STAGES)}", | ||
| ) | ||
| processor_type: str |
Contributor
There was a problem hiding this comment.
are we changing this to a string?
we actually did this for column types, which makes plugins easier to work with.
johnnygreco
approved these changes
Dec 17, 2025
andreatgretel
force-pushed
the
andreatgretel/chore/discriminator-field-for-processors
branch
from
cdd7cb2 to
a10f6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ProcessorConfigTtype which is used as explicit discriminator field insideDataDesignerConfig.Closes #117.